On Wed, 2012-11-28 at 00:51 +0100, Krzysztof Mazur wrote: > If you do this actually it's better to don't use patch 1/7 because > it introduces race condition that you found earlier.
Right. I've omitted that from the git tree I just pushed out. > With this patch you have still theoretical race that was fixed in patches > 5 and 8 in pppoatm series, but I never seen that in practice. And I think it's even less likely for br2684. At least with pppoatm you might have had pppd sending frames. But for br2684 they *only* come from its start_xmit function... which is serialised anyway. I do get strange oopses when I try to add BQL to br2684, but that's not something to be looking at at 1am... I *do* need the equivalent of your patch 4, which is the module_put race. -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
