On 23 November 2012 16:11, Lee Jones <lee.jo...@linaro.org> wrote:
>> > +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
>> > @@ -0,0 +1,18 @@
>> > +STMPE gpio
>> > +----------
>> > +
>> > +Required properties:
>> > + - compatible: "st,stmpe-gpio"
>
> ... but this is wrong.
>
>> > +Example:
>> > + stmpe_gpio {
>> > + compatible = "st,stmpe-gpio";
>> > + st,norequest-mask = <0x20>; //gpio 5 can't be used
>> > + };
>
> As is the example.
>
> So will be the the DT - if you've already written it.
Again, I believe these are required by the code you wrote in mfd-core.c
if (parent->of_node && cell->of_compatible) {
for_each_child_of_node(parent->of_node, np) {
if (of_device_is_compatible(np, cell->of_compatible)) {
pdev->dev.of_node = np;
break;
}
}
}
This matches compatible of child node with compatible of cell. And that's
why you have added that in your keypad mappings as well.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
