On Wed, Nov 21, 2012 at 06:41:07PM +0530, Philip, Avinash wrote:
[...]
> diff --git a/arch/arm/boot/dts/am335x-evm.dts 
> b/arch/arm/boot/dts/am335x-evm.dts
> index 9f65f17..4178ba4 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -44,6 +44,12 @@
>                               0x154 0x27      /* spi0_d0.gpio0_3, INPUT | 
> MODE7 */
>                       >;
>               };
> +
> +             ecap0_pins: backlight_pins {
> +                     pinctrl-single,pins = <
> +                             0x164 0x0       /* 
> eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */
> +                     >;

This looks kind of funky, but I see the rest of the file uses similar
formatting, so I guess it's okay.

> @@ -158,6 +174,13 @@
>                       gpio-key,wakeup;
>               };
>       };
> +
> +     backlight {
> +             compatible      = "pwm-backlight";

Maybe you don't want a tab between "compatible" and "=", but a space
instead.

Other than that, looks good:

Reviewed-by: Thierry Reding <thierry.red...@avionic-design.de>

Attachment: pgphgpr59hCBC.pgp
Description: PGP signature

Reply via email to