100%, will do.
On 19 November 2012 09:17, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Fri, Nov 16, 2012 at 06:54:43PM +0200, Johan Meiring wrote: >> This commit sorts out several coding style issues, including the use of C99 >> // comments, spaces at the start of lines, spaces before tabs, incorrect >> brace placement, and macros with complex values that have not been wrapped >> in parentheses. The only remaining issue is the use of typedefs in two >> instances, but that's something that the original author might need to have >> a look at. >> > > Could you line wrap your commit message at something like 72-73 > characters? I think that's they rule on email, but I forget. > > Normally we ask that people break these kinds of changes into > multiple patches. > [patch 1/x] Staging: wlags49_h2: wl_if.h: use tab indents > [patch 2/x] Staging: wlags49_h2: wl_if.h: fix comment style > etc... > >> +/* >> +#define HCF_MIN_COMM_QUALITY 0 >> +#define HCF_MAX_COMM_QUALITY 92 >> +#define HCF_MIN_SIGNAL_LEVEL 47 >> +#define HCF_MAX_SIGNAL_LEVEL 138 >> +#define HCF_MIN_NOISE_LEVEL 47 >> +#define HCF_MAX_NOISE_LEVEL 138 >> +#define HCF_0DBM_OFFSET 149 >> +*/ > > Just delete this dead code. > >> +#define SIOCSIWNETNAME (SIOCDEVPRIVATE+1) >> +#define SIOCGIWNETNAME (SIOCDEVPRIVATE+2) >> +#define SIOCSIWSTANAME (SIOCDEVPRIVATE+3) >> +#define SIOCGIWSTANAME (SIOCDEVPRIVATE+4) >> +#define SIOCSIWPORTTYPE (SIOCDEVPRIVATE+5) >> +#define SIOCGIWPORTTYPE (SIOCDEVPRIVATE+6) > > Could you put spaces around the '+' operator? > #define SIOCSIWNETNAME (SIOCDEVPRIVATE + 1) > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
