On Fri, Nov 16, 2012 at 11:02:05AM +0100, Rafael J. Wysocki wrote: > On Friday, November 16, 2012 10:12:46 AM Mika Westerberg wrote: > > On Fri, Nov 16, 2012 at 10:05:49AM +0200, Mika Westerberg wrote: > > > > > > One more thing, sometimes we want to assign the handle like in the case of > > > SPI controller driver we set the master->dev.acpi_handle. In that case we > > > can't use DEVICE_ACPI_HANDLE() as is. Should we just do something like: > > > > > > master->dev.acpi_handle = pdev->dev.acpi_handle; > > > > > > or should we introduce some new macro that supports this? > > > > Or we could just drop the cast from the macro and use the same. > > > > #define DEVICE_ACPI_HANDLE(dev) ((dev)->acpi_handle) > > Well, I'm not sure. Perhaps it's better to add a new macro, like > ACPI_HANDLE(dev), defined as above and use it going forward (we can then > phase out the old one gradually).
Yeah, that sounds good. > However, let's leave the patches in this series as they are for now, we can > add that macro in a separate patch later. OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
