On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
>
> > > - if (timeout < 0) {
> > > - dev_err(&dev->adev->dev,
> > > - "wait_for_completion_timeout "
> > > - "returned %d waiting for event\n", timeout);
> > > - status = timeout;
> > > - }
> > > -
> > No, it is wrong. You need to update the status variable in the case of
> > timeout.
>
> Looking at the patch context, such code comes later.
But it causes regressions; without looking at the "later" code, we can't afford
merging
this code now.
regards/srinidhi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
