On 11/13/2012 11:59 AM, Yinghai Lu wrote: >> >> The changes to init_mem_mapping are a bit iffy but they aren't too >> unreasonable. >> Overall the patch is OK even though I would certainly appreciate more >> comments and better variable names (real_end?), see below. > > real_end is not good? > > xen put big reserved range between real_end and end. > > that real_end is some kind of end of real usable areas. > > so change to real_usable_end or usable_end? >
A description of a variable that includes the words "some kind of" clearly indicates major confusion. We need to know what the semantics are, here. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/