On Fri, Nov 9, 2012 at 6:16 PM, Stephen Warren <swar...@wwwdotorg.org> wrote:
> [Me]
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + if (res) {
>> + npct->prcm_base = devm_ioremap(&pdev->dev, res->start,
>> + resource_size(res));
>> + if (!npct->prcm_base) {
>> + dev_err(&pdev->dev,
>> + "failed to ioremap PRCM registers\n");
>> + return -ENOMEM;
>> + }
>> + } else {
>> + dev_info(&pdev->dev,
>> + "No PRCM base, assume no ALT-Cx control is
>> available\n");
>> + }
>
> Where is "assume no ALT-Cx control is available" implemented; I don't
> see anything that uses npct->prcm_base to conditionally enable/block any
> features. Is it just assumed that the DT won't contain any entries that
> trigger writes to the PRCM registers? That seems fragile; it could cause
> a "user"-triggered kernel crash.
Yeah. That's been in for a while, so this patch in itself is not making
things more fragile, it came with the first Alt-Cx patch.
So it is indeed based on good faith in the maps.
I'm poking Jean-Nicolas to have a look at hardening
this with some check, ping!
> Aside from that, this seems fine. Much smaller than V1:-)
Yeah, thanks for poking us...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
