On 11/08/2012 04:55 AM, Linus Walleij wrote: > From: Jonas Aaberg <jonas.ab...@stericsson.com> > > Currently there are some unnecessary criss-cross > dependencies between the PRCMU driver in MFD and a lot of > other drivers, mainly because other drivers need to poke > around in the PRCM register range. > > In cases like this there are actually just a few select > registers that the pinctrl driver need to read/modify/write, > and it turns out that no other driver is actually using > these registers, so there are no concurrency issues > whatsoever. > > So: don't let the location of the register range complicate > things, just poke into these registers directly and skip > a layer of indirection.
Do you actually need to store the run-time data in struct nmk_pinctrl_soc_data too? I would have expected all the soc_data pointers to remain const, and to store the runtime register pointer somewhere else, and perhaps pass it as a separate parameter to the relevant init functions; wouldn't that make the patch much smaller? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
