On Wed, Oct 31, 2012 at 03:12:36PM +0800, Fengguang Wu wrote: > On Wed, Oct 31, 2012 at 03:00:54PM +0800, Yuanhan Liu wrote: > > There are 2 issues with current code: > > > > 1. redefinition of 'gpio_cansleep': > > include/linux/gpio.h:60:19: error: redefinition of 'gpio_cansleep' > > include/asm-generic/gpio.h:212:19: note: previous definition of > > 'gpio_cansleep' was here > > > > The root cause is include/linux/gpio.h has a defintion of it. And if > > CONFIG_GPIOLIB is not set, include/asm-generic/gpio.h has another > > definition. > > > > 2. include/linux/gpio.h:62:2: error: implicit declaration of function > > '__gpio_cansleep' > > > > Only happens when CONFIG_GPIOLIB is not set, too. Since it called > > gpiolib functions without putting something like: #ifdef CONFIG_GPIOLIB > > > > So, move those functions into proper section at > > include/asm-generic/gpio.h would resolve 2 above issues. > > The patch introduces new build errors:
Ooops. I checked the log at build server and posted it after finding no errors. Seems that the test hasn't been finished? Sorry for the nosiy. Will send v2 then. Thanks! > > yuanhan:gpio-fixes [2/2] db1a5a0 blackfin-BF526-EZBRD_defconfig > > [error] > arch/blackfin/include/asm/gpio.h:197:19: error: redefinition of > 'gpio_get_value' > arch/blackfin/include/asm/gpio.h:205:20: error: redefinition of > 'gpio_set_value' > arch/blackfin/include/asm/gpio.h:213:19: error: redefinition of > 'gpio_cansleep' > arch/blackfin/include/asm/gpio.h:218:19: error: redefinition of 'gpio_to_irq' > > yuanhan:gpio-fixes [2/2] db1a5a0 blackfin-TCM-BF537_defconfig > > [error] > include/asm-generic/gpio.h:225:19: error: redefinition of 'gpio_get_value' > include/asm-generic/gpio.h:231:20: error: redefinition of 'gpio_set_value' > include/asm-generic/gpio.h:242:19: error: redefinition of 'gpio_to_irq' > > yuanhan:gpio-fixes [2/2] db1a5a0 sh-rsk7269_defconfig > > [error] > arch/sh/include/asm/gpio.h:27:19: error: redefinition of 'gpio_get_value' > arch/sh/include/asm/gpio.h:32:20: error: redefinition of 'gpio_set_value' > arch/sh/include/asm/gpio.h:37:19: error: redefinition of 'gpio_cansleep' > arch/sh/include/asm/gpio.h:42:19: error: redefinition of 'gpio_to_irq' > > yuanhan:gpio-fixes [2/2] db1a5a0 avr32-atngw100_defconfig > > [error] > arch/avr32/mach-at32ap/include/mach/gpio.h:18: error: redefinition of > 'gpio_get_value' > include/asm-generic/gpio.h:203: error: previous definition of > 'gpio_get_value' was here > arch/avr32/mach-at32ap/include/mach/gpio.h:23: error: redefinition of > 'gpio_set_value' > include/asm-generic/gpio.h:208: error: previous definition of > 'gpio_set_value' was here > arch/avr32/mach-at32ap/include/mach/gpio.h:28: error: redefinition of > 'gpio_cansleep' > include/asm-generic/gpio.h:213: error: previous definition of 'gpio_cansleep' > was here > arch/avr32/mach-at32ap/include/mach/gpio.h:34: error: redefinition of > 'gpio_to_irq' > include/asm-generic/gpio.h:218: error: previous definition of 'gpio_to_irq' > was here > > Thanks, > Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
