Hi Tony,
> @@ -124,6 +156,12 @@ static int __devinit pwm_probe(struct
> platform_device *pdev)
> chip->chip.base = -1;
> chip->chip.npwm = VT8500_NR_PWMS;
>
> + chip->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR_OR_NULL(chip->clk)) {
> + dev_err(&pdev->dev, "clock source not specified\n");
> + return PTR_ERR(chip->clk);
> + }
> +
Do you want IS_ERR() rather than IS_ERR_OR_NULL() here ?
Otherwise you may return PTR_ERR(NULL).
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
