Thanks Alan. > The second error check is unreachable because the lock function isn't assigned > to ret > > Signed-off-by: Alan Cox <a...@linux.intel.com> Acked-by: Ramakrishna Pallala <ramakrishna.pall...@intel.com>
> --- > > drivers/power/max17042_battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/max17042_battery.c > b/drivers/power/max17042_battery.c > index 74abc6c..73b432d 100644 > --- a/drivers/power/max17042_battery.c > +++ b/drivers/power/max17042_battery.c > @@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip > *chip) > __func__); > return -EIO; > } > - max17042_verify_model_lock(chip); > + ret = max17042_verify_model_lock(chip); > if (ret) { > dev_err(&chip->client->dev, "%s lock verify failed\n", > __func__);