On 10/22/2012 09:50 PM, Mark Brown wrote: > On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: >> From: Wei Yongjun <yongjun_...@trendmicro.com.cn> >> >> The variable oldstatus is initialized but never used >> otherwise, so remove the unused variable. > Applied, thanks. However for changes like this you should really > consider in your changelog why the variable is unused - is the bug that > the result is ignored or that it is needlessly generated?
Yes, I will review every patch before send out them. I will try to fix it if it is a bug, but some times, I does not have all of those knowledge, many place have unused variables, but it is hard to find why this is unused, so maybe some times I send the wrong patch. Like this patch: https://patchwork.kernel.org/patch/1606481/ It is found by the same rule, but I fixed it as a bug. Thanks, Yongjun Wei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
