On Fri, Oct 19, 2012 at 2:46 AM, <[email protected]> wrote: > From: Yasuaki Ishimatsu <[email protected]> > > When calling unregister_node(), the function shows following message at > device_release(). > > "Device 'node2' does not have a release() function, it is broken and must > be fixed." > > The reason is node's device struct does not have a release() function. > > So the patch registers node_device_release() to the device's release() > function for suppressing the warning message. Additionally, the patch adds > memset() to initialize a node struct into register_node(). Because the node > struct is part of node_devices[] array and it cannot be freed by > node_device_release(). So if system reuses the node struct, it has a garbage. > > CC: David Rientjes <[email protected]> > CC: Jiang Liu <[email protected]> > Cc: Minchan Kim <[email protected]> > CC: Andrew Morton <[email protected]> > CC: KOSAKI Motohiro <[email protected]> > Signed-off-by: Yasuaki Ishimatsu <[email protected]> > Signed-off-by: Wen Congyang <[email protected]>
I still think node array should be converted node pointer array and node_device_release() free memory as other typical drivers. However, this is acceptable as first step. Acked-by: KOSAKI Motohiro <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
