On Wed, Oct 17, 2012 at 01:13:51PM +0200, Borislav Petkov wrote: > +ssize_t device_store_bool(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t size) > +{ > + struct dev_ext_attribute *ea = to_ext_attr(attr); > + u8 bval; > + > + if (kstrtou8(buf, 10, &bval) < 0) > + return -EINVAL; > + > + *(bool *)ea->var = !!bval; > + > + return size; > +} > +EXPORT_SYMBOL_GPL(device_store_bool);
Wouldn't it be nice to be able to accept 'y' 'Y' 'n' 'N' '0' and '1' like the module bool parameter code does? That would make things a bit more consistent, and possibly allow you to use this function for the module sysfs file handling as well. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/