[PATCH 2/2] backlight: tosa: use devm_gpio_request_one

[Jingoo Han]

By using devm_gpio_request_one it is possible to set the direction
and initial value in one shot. Thus, using devm_gpio_request_one
can make the code simpler.

Signed-off-by: Jingoo Han <jg1....@samsung.com>
Cc: Richard Purdie <rpur...@rpsys.net>
Cc: Dmitry Baryshkov <dbarysh...@gmail.com>
---
 drivers/video/backlight/tosa_bl.c  |    6 ++----
 drivers/video/backlight/tosa_lcd.c |    8 ++------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/video/backlight/tosa_bl.c 
b/drivers/video/backlight/tosa_bl.c
index 49342e1..60f258c 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -92,14 +92,12 @@ static int __devinit tosa_bl_probe(struct i2c_client 
*client,
 
        data->comadj = sharpsl_param.comadj == -1 ? COMADJ_DEFAULT : 
sharpsl_param.comadj;
 
-       ret = devm_gpio_request(&client->dev, TOSA_GPIO_BL_C20MA, "backlight");
+       ret = devm_gpio_request_one(&client->dev, TOSA_GPIO_BL_C20MA,
+                               GPIOF_OUT_INIT_LOW, "backlight");
        if (ret) {
                dev_dbg(&data->bl->dev, "Unable to request gpio!\n");
                return ret;
        }
-       ret = gpio_direction_output(TOSA_GPIO_BL_C20MA, 0);
-       if (ret)
-               return ret;
 
        i2c_set_clientdata(client, data);
        data->i2c = client;
diff --git a/drivers/video/backlight/tosa_lcd.c 
b/drivers/video/backlight/tosa_lcd.c
index 33047a6..00a8f21 100644
--- a/drivers/video/backlight/tosa_lcd.c
+++ b/drivers/video/backlight/tosa_lcd.c
@@ -193,17 +193,13 @@ static int __devinit tosa_lcd_probe(struct spi_device 
*spi)
        data->spi = spi;
        dev_set_drvdata(&spi->dev, data);
 
-       ret = devm_gpio_request(&spi->dev, TOSA_GPIO_TG_ON, "tg #pwr");
+       ret = devm_gpio_request_one(&spi->dev, TOSA_GPIO_TG_ON,
+                               GPIOF_OUT_INIT_LOW, "tg #pwr");
        if (ret < 0)
                goto err_gpio_tg;
 
        mdelay(60);
 
-       ret = gpio_direction_output(TOSA_GPIO_TG_ON, 0);
-       if (ret < 0)
-               goto err_gpio_tg;
-
-       mdelay(60);
        tosa_lcd_tg_init(data);
 
        tosa_lcd_tg_on(data);
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/