On Sun, Oct 14, 2012 at 10:38 PM, YAMANE Toshiaki <yamaneto...@gmail.com> wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then
> pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <yamaneto...@gmail.com>
> ---
> drivers/staging/comedi/drivers/usbdux.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c
> b/drivers/staging/comedi/drivers/usbdux.c
> index b536bba..46c5bfb 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -2386,14 +2386,12 @@ static int usbdux_attach_usb(struct comedi_device
> *dev,
> down(&start_stop_sem);
> this_usbduxsub = usb_get_intfdata(uinterf);
> if (!this_usbduxsub || !this_usbduxsub->probed) {
> - printk(KERN_ERR
> - "comedi%d: usbdux: error: attach_usb failed, not
> connected\n",
> - dev->minor);
> + dev_err(&uinterf->dev,
> + "usbdux: error: attach_usb failed, not connected\n");
> ret = -ENODEV;
> } else if (this_usbduxsub->attached) {
> - printk(KERN_ERR
> - "comedi%d: usbdux: error: attach_usb failed, already
> attached\n",
> - dev->minor);
> + dev_err(&uinterf->dev,
> + "error: attach_usb failed, already attached\n");
> ret = -ENODEV;
> } else
> ret = usbdux_attach_common(dev, this_usbduxsub);
> --
> 1.7.9.5
>
I cannot judge which is better or not ...
--
Regards,
YAMANE Toshiaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
