On Fri, Oct 12, 2012 at 11:57:00AM +0200, Steffen Persvold wrote: > This patch looks very clean and should serve our purpose as well (I'll > double check with Daniel).
Thanks. I'll run it today or next week to check whether it works as expected - will let you know if there are issues. > Regarding the size of the "node" variable, you asked before. The > theoretical maximum number of AMD NBs we can have in a confederated > NumaConnect system _today_ is 8*4096 (8 NBs per system, 4096 > systems) so technically this could fit into a u16 instead of a u32 > (you'll have to shift left by 3 instead of 8). > > However, to allow some flexibility I think a u32 is better and I > think we can live with those two extra bytes per struct member, or ? Yeah, we can leave it u32 (I did it so in my patch) because of two reasons: * node_to_amd_nb gets an int as an argument * compiler padding On the largest of your systems that's 2*8*4096 = 64K but I'll go ahead and assume you have enough memory on those so that nobody cares about 64K there. :-) On Fri, Oct 12, 2012 at 05:46:28PM +0800, Daniel J Blueman wrote: > Nice. Sorry for the delays in getting back to you, since I'm just > chasing down the last issue we see with kobjects, amongst other work. > > I'll check this out next week, and thanks for keeping an eye on it! Sure. It is probably convenient that you're busy currently - I can test it here first and fixup any issues before you do. I'll send an official version with changelog etc after having tested it here. Thank you both. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
