From: Florian Zumbiehl <fl...@florz.de> Date: Mon, 8 Oct 2012 03:51:58 +0200
> This version completely avoids any new state that could need to be spilled > to RAM, and instead re-checks existence and non-zeroness of the tag. What > do you think? At a high level it looks fine and doesn't have the problems mentioned earlier. But I wonder if it breaks things, since you do the assignment so late we no longer handle the case where the VLAN device's MAC address matches the packet MAC address and the top-level device's does not. That's handled by logic in vlan_do_receive() which checks for PACKET_OTHERHOST. But you're going to unconditionally set PACKET_OTHERHOST, overriding any decision that code makes. This turns out to be a really non-trivial area and it's going to take some time to get this right and audit the change appropriately. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
