Dear Axel Lin,
On Sun, 30 Sep 2012 16:23:27 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel....@ingics.com>
> ---
> drivers/gpio/gpio-mvebu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 902af43..7a874129 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -381,11 +381,13 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d,
> unsigned int type)
> u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
> u &= ~(1 << pin);
> writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
> + break;
> case IRQ_TYPE_EDGE_FALLING:
> case IRQ_TYPE_LEVEL_LOW:
> u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
> u |= 1 << pin;
> writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
> + break;
> case IRQ_TYPE_EDGE_BOTH: {
> u32 v;
>
> @@ -401,6 +403,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d,
> unsigned int type)
> else
> u &= ~(1 << pin); /* rising */
> writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
> + break;
> }
> }
> return 0;
Doh, I missed this when converting the if() series to a switch()
construct. It was just pure luck that it worked. Good catch indeed.
Acked-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
