On Sat, Sep 29, 2012 at 10:27:44PM +0200, Geert Uytterhoeven wrote: > On Sat, Sep 29, 2012 at 10:10 PM, Joe Perches <j...@perches.com> wrote: > >> @@ -88,7 +88,7 @@ static int do_aio(aio_context_t ctx, enum aio_type type, > >> int fd, char *buf, > >> iocbp->aio_nbytes = sizeof(c); > >> break; > >> default: > >> - printk(UM_KERN_ERR "Bogus op in do_aio - %d\n", type); > >> + printk(KERN_ERR "Bogus op in do_aio - %d\n", type); > > > > Maybe a follow-on patch to convert these to pr_<level>? > > That requires adding pr_<level> to arch/um/include/shared/user.h first. > Or to avoid duplication, extracting the pr_<level> definitions from > include/linux/printk.h to a new header file, and preincluding that one for > the user part of UML, too.
Yecchhh.... Just how many of those pre-includes do you want to add? Seriously, if we get enough of those, it might make more sense to take them into a separate directory and add it to search paths, including that for userland objects of uml. If not, I'd rather copy them to include/generated in arch/um/Makefile and explicitly #include <generated/foo.h> them from user.h. It's trivially doable and as long as we have relatively few of those guys it's less PITA... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
