The original code dereferenced "msb" after freeing it.

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
index c815fe5..a8e8915 100644
--- a/drivers/memstick/core/ms_block.c
+++ b/drivers/memstick/core/ms_block.c
@@ -1983,9 +1983,9 @@ static int msb_disk_release(struct gendisk *disk)
                        msb->usage_count--;
 
                if (!msb->usage_count) {
-                       kfree(msb);
                        disk->private_data = NULL;
                        idr_remove(&msb_disk_idr, msb->disk_id);
+                       kfree(msb);
                        put_disk(disk);
                }
        }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to