>>> On 26.09.12 at 13:16, Ingo Molnar <mi...@kernel.org> wrote:
> * Jan Beulich <jbeul...@suse.com> wrote: > >> >>> On 26.09.12 at 10:28, Tao Guo <glorious...@gmail.com> wrote: >> > gas in binutils(2.16.91) could not parse parentheses within macro >> > parameters unless fully parenthesized, and this is a workaround to >> > make old gas work without generating below errors: >> > arch/x86/kernel/entry_64.S: Assembler messages: >> > arch/x86/kernel/entry_64.S:387: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:389: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:390: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:391: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:392: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:393: Error: too many positional arguments >> > arch/x86/kernel/entry_64.S:394: Error: too many positional arguments >> > >> > Signed-off-by: Tao Guo <glorious...@gmail.com> >> >> This looks okay now to me, but I'm somewhat reluctant to >> formally ack it given that we know how broken those particular >> gas versions are. > > Well, assuming Tao Guo test-booted a kernel build with this old > GAS version, we could apply this patch on a best-effort basis - > the changes don't look particularly ugly. If other, unacceptable > uglies or fragilities come up then we might balk. > > Agreed? Fine with me. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
