Hi Feng,
On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote:
> As suggested by Arnaldo, many scripts have their own usages and need
> capture specific events or tracepoints, so only those scripts whose
> targe events match the events in current perf data file should be
> listed in the script browser menu.
>
> This patch will add the event match checking.
>
> Signed-off-by: Feng Tang <feng.t...@intel.com>
> ---
> tools/perf/builtin-script.c | 76
> +++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 73 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 4e2f10f..37a0df8 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -1031,6 +1031,63 @@ static int list_available_scripts(const struct option
> *opt __maybe_unused,
> }
>
> /*
> + * Some scripts specify the required events in their "xxx-record" file,
> + * this function will check if the events in perf.data match those
> + * mentioned in the "xxx-record".
> + */
> +static int check_ev_match(char *dir_name, char *scriptname,
> + struct perf_session *session)
> +{
> + char filename[MAXPATHLEN], evname[128];
> + char line[BUFSIZ], *p, *temp;
> + struct perf_evsel *pos;
> + int match;
> + FILE *fp;
> +
> + sprintf(filename, "%s/bin/%s-record", dir_name, scriptname);
> +
> + fp = fopen(filename, "r");
> + if (!fp)
> + return -1;
> +
> + while (fgets(line, sizeof(line), fp)) {
> + p = ltrim(line);
> + if (strlen(p) == 0 ||*p == '#')
> + continue;
> +
> + while (strlen(p)) {
> + temp = strstr(p, "-e");
> + if (!temp)
> + break;
> +
> + p = temp + 3;
> + temp = strchr(p, ' ');
> + snprintf(evname, (temp - p) + 1, "%s", p);
It can't recognize extra spaces, multiple events connected by commas,
event groups and probably more.. So I think it'd better if we can use
parse_events() here - but w/o an evlist. Jiri, what do you think?
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
