Hi Ohad, > Thanks, it looks good. > > It might be safer though to invoke ->setup() in probe/remove, instead > of in start/stop (just like you essentially did before). > > This way we don't assume that stop is always called before remove (as > assumption that might be implicitly valid today, but may break in the > future). > > If you want, I can just change that before applying.
Sounds good, please just go ahead and change this before applying. Thank you. Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
