On Wed, 19 Sep 2012 22:38:25 +0200 Jiri Pirko <j...@resnulli.us> wrote:
> You cannot call sky2_set_multicast() directly here. It is called from > __dev_set_rx_mode(). You would have to take at lease netif_addr_lock() > here. I think that clearer is to remember computed value.... Ugh, it would mean changing link_up to being done via workqueue. But your code wasnt safe against changes to values from set_multicast race either. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/