> -----Original Message----- > From: Shaun Ruffell [mailto:sruff...@digium.com] > Sent: Wednesday, September 19, 2012 11:05 AM > To: Xie Shaohui-B21989 > Cc: linux-e...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > a...@linux-foundation.org; avoront...@mvista.com; linux- > ker...@vger.kernel.org; grant.lik...@secretlab.ca > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > On Mon, Sep 17, 2012 at 10:32:59AM +0000, Xie Shaohui-B21989 wrote: > > > -----Original Message----- > > > From: Shaun Ruffell [mailto:sruff...@digium.com] > > > Sent: Saturday, September 15, 2012 2:22 AM > > > To: Xie Shaohui-B21989 > > > Cc: linux-e...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > a...@linux-foundation.org; avoront...@mvista.com; linux- > > > ker...@vger.kernel.org; grant.lik...@secretlab.ca > > > Subject: Re: [PATCH] edac/85xx: fix error handle of > > > mpc85xx_mc_err_probe > > > > > > On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: > > > > Error handle in case of DDR ECC off is wrong, sysfs entries have > > > > not been created, so edac_mc_free which frees a mci instance > > > > should not be called. > > > > Also, free mci's memory in this case. > > > > > > Jus FYI: I ran into the same error in edac_mc_free() which I > > > resolved in a slightly different way in some patches I sent > > > previously. [1] > > > > > > [1] https://lkml.org/lkml/2012/9/14/475 > > > > [S.H] Thanks! I did not aware of this patch when one of my colleague > > asked me to have a look at the issue, It could save me some time if I > > saw this patch earlier. :( > > > > BTW: seems you are using a different kernel tree with mine. > > On the chance that I missing something important: Why do you say I was > running a different kernel tree? I was against 3.6-rc2 when I original > hit the problem. [S.H] I'm using 3.6-rc4, and some codes in your patch I did not find them in 3.6-rc4.
Best Regards, Shaohui Xie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
