On Fri, Sep 14, 2012 at 06:13:11PM +0800, Xiao Guangrong wrote: > On 09/14/2012 05:59 PM, Xiao Guangrong wrote: > > > + return FNAME(prefetch_gpte)(vcpu, sp, spte, gptep[i], true); > > Sorry, this was wrong. Update this patch. > > [PATCH v2 5/5] KVM: MMU: introduce FNAME(prefetch_gpte) > > The only different thing between FNAME(update_pte) and FNAME(pte_prefetch) > is that the former is allowed to prefetch gfn from dirty logged slot, so > introduce a common function to prefetch spte > > Signed-off-by: Xiao Guangrong <xiaoguangr...@linux.vnet.ibm.com>
IMHO, for the human reader, the meaning of the two functions is different and therefore separation is justified. Moreover they already share common code via FNAME(prefetch_invalid_gpte) (which BTW, is a confusing name because the function does not prefetch gpte, it validates gpte). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
