On 09/12, Srikar Dronamraju wrote: > > * Oleg Nesterov <o...@redhat.com> [2012-09-03 17:26:16]: > > > Note: send_sig(SIGTRAP) is not actually right, we need send_sigtrap(). > > Are you pointing to the info field not being filled? or are there other > problems?
Yes. Also, I am not sure but I feel we should move this into generic code somehow. We will see. > > But this needs more changes, handle_swbp() does the same and this is > > equally wrong. > > send_sigtrap() is arch specific and defined for only few archs. > we would have to force. Yes, but we have user_single_step_siginfo(), probably this is enough. > But these are not related to the patch. Agreed, lets do this later. > Acked-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com> Thanks! Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/