On Mon, Sep 10, 2012 at 10:31 PM, Naveen N. Rao <naveen.n....@linux.vnet.ibm.com> wrote: > + if (mce_bios_cmci_threshold) > + printk_once(KERN_INFO > + "bios_cmci_threshold: Using bios-set threshold values > for CMCI");
Do we really need this message? The user knows whether they gave the command line option or not (and can check in /proc/cmdline if they forgot whether they did). If it is needed, then you should add a "\n" to it. > + if (mce_bios_cmci_threshold && bios_wrong_thresh) { > + printk_once(KERN_INFO > + "bios_cmci_threshold: Some banks do not have valid > thresholds set"); > + printk_once(KERN_INFO > + "bios_cmci_threshold: Make sure your BIOS supports > this boot option"); Also need "\n" -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/