On 07.09.12 11:20:19, David Ahern wrote: > I see now... intel returns ENOTSUP if exclude_guest is not set, amd > returns EINVAL if it is set. > > For the AMD case the fallback_missing_features code kicks in for > perf-top and perf-record; I just need to fix up the pr_debug for that case.
It is EOPNOTSUP. I preferred returning EOPNOTSUP too. But then I saw that fallback code is implemented to work mostly with EINVAL. It seems to be the default answer to a syscall. ;) There are several pieces of code in perf that implement fallback code, it's hard to find it all and this already caused some bugs in the past. I was looking at this to unify it, but it was too much effort. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
