Adrian Hunter <adrian.hun...@intel.com> writes: > On 31/08/12 11:15, Andrew Morton wrote: >> On Fri, 31 Aug 2012 01:07:24 -0700 Michel Lespinasse <wal...@google.com> >> wrote: >> >>> On Fri, Aug 31, 2012 at 1:01 AM, Adrian Hunter <adrian.hun...@intel.com> >>> wrote: >>>> This breaks tools/perf build in linux-next: >>>> >>>> ../../lib/rbtree.c: In function 'rb_insert_color': >>>> ../../lib/rbtree.c:95:9: error: 'true' undeclared (first use in this >>>> function) >>>> ../../lib/rbtree.c:95:9: note: each undeclared identifier is reported only >>>> once for each function it appears in >>>> ../../lib/rbtree.c: In function '__rb_erase_color': >>>> ../../lib/rbtree.c:216:9: error: 'true' undeclared (first use in this >>>> function) >>>> ../../lib/rbtree.c: In function 'rb_erase': >>>> ../../lib/rbtree.c:368:2: error: unknown type name 'bool' >>>> make: *** [util/rbtree.o] Error 1 >>> >>> I thought Andrew had a patch >>> rbtree-adjust-root-color-in-rb_insert_color-only-when-necessary-fix-perf-compilation >>> that fixed this though a Makefile change ? >> >> Yup. But it's unclear why we should include the header via the cc >> command line? > > Dunno > > AFAICS tools/perf/util/include/linux is for fixing up the > differences between kernel headers and exported kernel headers. > Hence my change: > > diff --git a/tools/perf/util/include/linux/rbtree.h > b/tools/perf/util/include/linux/rbtree.h > index 7a243a1..2a030c5 100644 > --- a/tools/perf/util/include/linux/rbtree.h > +++ b/tools/perf/util/include/linux/rbtree.h > @@ -1 +1,2 @@ > +#include <stdbool.h> > #include "../../../../include/linux/rbtree.h" > > Alex?
Whichever color like best. :) Consider my initial patch a bugreport. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
