Hello, Lai. On Thu, Aug 30, 2012 at 12:51:54AM +0800, Lai Jiangshan wrote: > When hotplug happens, the plug code will also grab the manager_mutex, > it will break too_many_workers()'s assumption, and make too_many_workers() > ugly(kick the timer wrongly, no found bug). > > To avoid assumption-coruption, we add the original POOL_MANAGING_WORKERS back.
I don't think we're gaining anything with this and I'd like to confine management state within the mutex only. If too_many_workers() firing spuriously while CPU up/down is in progress, just add a comment explaining why it's a non-problem (actual worker management never happens while cpu up/down holds manager positions). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/