On Mon, 2012-08-20 at 06:56 +0000, 함명주 wrote:
> > From: anish kumar <anish198519851...@gmail.com>
> >
> > Instead of "const char **supported_cable" it is better to have
> > it as "const char *const *supported_cable".
> >
> > Signed-off-by: anish kumar <anish198519851...@gmail.com>
>
> Could you please elaborate on why it's better?
>
> (Is this fixing the using the standard naming issue Mark mentioned before?)
No, It is what Lars(Lars-Peter Clausen) mentioned when he was doing the
review earlier.It is nothing but a general practise as cable_names is
constant.
>
>
> Cheers!
> MyungJoo
>
> > ---
> > include/linux/extcon.h | 2 +-
> > include/linux/extcon/extcon-adc-jack.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> > index cdd4014..a6bcc29 100644
> > --- a/include/linux/extcon.h
> > +++ b/include/linux/extcon.h
> > @@ -111,7 +111,7 @@ struct extcon_cable;
> > struct extcon_dev {
> > /* --- Optional user initializing data --- */
> > const char *name;
> > - const char **supported_cable;
> > + const char *const *supported_cable;
> > const u32 *mutually_exclusive;
> >
> > /* --- Optional callbacks to override class functions --- */
> > diff --git a/include/linux/extcon/extcon-adc-jack.h
> > b/include/linux/extcon/extcon-adc-jack.h
> > index 20e9eef..f27f2e8 100644
> > --- a/include/linux/extcon/extcon-adc-jack.h
> > +++ b/include/linux/extcon/extcon-adc-jack.h
> > @@ -60,7 +60,7 @@ struct adc_jack_pdata {
> > /*
> > * The last entry should be NULL
> > */
> > - const char **cable_names;
> > + const char *const *cable_names;
> > /* The last entry's state should be 0 */
> > struct adc_jack_cond *adc_conditions;
> >
> > --
> > 1.7.1
> >
> >
> >
> >
> >
> >
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
