Variable ret is always evaluated as true, so we don't need to check it.

Signed-off-by: Matthias Brugger <mbrug...@iseebcn.com>
---
 drivers/usb/musb/omap2430.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 5fdb9da..2d207c6 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -140,7 +140,6 @@ static void omap2430_musb_set_vbus(struct musb *musb, int 
is_on)
        struct usb_otg  *otg = musb->xceiv->otg;
        u8              devctl;
        unsigned long timeout = jiffies + msecs_to_jiffies(1000);
-       int ret = 1;
        /* HDRC controls CPEN, but beware current surges during device
         * connect.  They can trigger transient overcurrent conditions
         * that must be ignored.
@@ -164,12 +163,11 @@ static void omap2430_musb_set_vbus(struct musb *musb, int 
is_on)
                                if (time_after(jiffies, timeout)) {
                                        dev_err(musb->controller,
                                        "configured as A device timeout");
-                                       ret = -EINVAL;
                                        break;
                                }
                        }
 
-                       if (ret && otg->set_vbus)
+                       if (otg->set_vbus)
                                otg_set_vbus(otg, 1);
                } else {
                        musb->is_active = 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to