From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Wednesday, August 15, 2012 11:02 PM
>> >>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - >1); >> >>>> ... >> >>>> + strcpy(netdev->name, "eth%d"); >> >>>> + retval = register_netdev(netdev); >> >>> >> >>>The strcpy is unnecessary, alloc_etherdev already sets that. >> >> >> >> The strcpy is useful. netdev->name is set as pci_name in front. So the >> >> strcpy >> >restores it. >> > >> >Are you doing this just to influence the initial driver log messages? >> >> Yes. >> >> > >> >Don't do that, it's gross. >> >> Ok, I will remove it. > >Before the driver is registered, use dev_info() type of logging. Ok, I will do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
