2012-08-10 (금), 15:22 -0700, Cody P Schafer: > In kallsyms_parse() when calling process_symbol() (a callback argument > to kallsyms_parse()), we pass start as both start & end (ie: > start=start, end=start). > > In map__process_kallsym_symbol(), the length is calculated as 'end - start + > 1', > making the length 1, not 0. > > Essentially, start & end define an inclusive range. >
This seems not needed any more due to the patch #2, right? Thanks, Namhyung > Signed-off-by: Cody P Schafer <c...@linux.vnet.ibm.com> > --- > tools/perf/util/symbol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c > index f02de8a..891f83c 100644 > --- a/tools/perf/util/symbol.c > +++ b/tools/perf/util/symbol.c > @@ -605,7 +605,7 @@ int kallsyms__parse(const char *filename, void *arg, > > /* > * module symbols are not sorted so we add all > - * symbols with zero length and rely on > + * symbols, setting length to 1, and rely on > * symbols__fixup_end() to fix it up. > */ > err = process_symbol(arg, symbol_name, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
