On Sat, 10 Feb 2001, Jeff Garzik wrote:
> 1) Bug: Introduced memory leak by replacing "goto err_out" with "return
> err"
> 2) Sole usage of 'err' -- it should be scoped inside the pdev!=NULL
> check.
Will fix up later.
> > - int cards_found = 0;
> > + int cards_found;
> Rejected. Introduces bug. That zero is required!
Refresh my memory here. I thought unitialised vars go to bss,
and get zeroed at boot time ?
> rejected -- already in AC patches (and merged into my tree as well)
Odd, I diffed against the latest AC patch.
> Rejected. The maintainer clearly wanted the "/* = 0 */" present, yet
> you remove them. I'm suspicious of the acpi_idle_state initialization
> removal as well, but can't check it quickly at present (acpi_idle_state
> is gone in my tree)
Ok, I'll assume you've got the pci_enable stuff already cleaned there.
> All the rest were applied.
Great :) Thanks Jeff..
regards,
Dave.
--
| Dave Jones. http://www.suse.de/~davej
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
