On Sun, Aug 05, 2012 at 12:50:54PM +0200, Linus Walleij wrote: > On Mon, Jul 30, 2012 at 9:47 AM, Thierry Reding > <thierry.red...@avionic-design.de> wrote: > > On Sun, Jul 29, 2012 at 07:13:57PM +0200, Linus Walleij wrote: > >> On Mon, Jul 23, 2012 at 1:59 PM, Thierry Reding > >> <thierry.red...@avionic-design.de> wrote: > > >> > +- interrupt-controller: Marks the device as an interrupt controller. > >> > +- nr-gpios: The number of pins supported by the controller. > >> > >> These two last things look very generic, like something every GPIO > >> driver could want to expose. > > > > As Arnd mentioned, interrupt-controller is a generic property required > > by all interrupt controller nodes. Perhaps it shouldn't be listed in the > > DT binding for this driver. > > After reading Rob's etc comments I think nr-gpios should be in this > binding, but interrupt-controller seems like it should go into > Documentation/devicetree/bindings/gpio/gpio.txt > can you take care of this? > > (Anyone agains, beat me up...)
Perhaps this should go into some more generic document (perhaps something like Documentation/devicetree/bindings/interrupts.txt) to describe the common properties for interrupt controllers and refer to that document in bindings that use them. It might be good to document the #interrupt-cells property as well, with the common meaning as defined by the various irq_domain_ops.xlate() callbacks. Do you want me to replace occurrences of this in other binding documents by a reference to the new document while I'm at it? Thierry
pgpOdea7mUDdh.pgp
Description: PGP signature
