> Do not leak memory by updating pointer with potentially NULL realloc return
> value.
> There is no need to preserve data in the buffer,
> so replace krealloc() by kfree()-kmalloc() pair.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru>
Acked-by: Peter Meerwald <pme...@pmeerw.net>
> ---
> drivers/iio/light/adjd_s311.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c
> index 1cbb449..9a99f43 100644
> --- a/drivers/iio/light/adjd_s311.c
> +++ b/drivers/iio/light/adjd_s311.c
> @@ -271,9 +271,10 @@ static int adjd_s311_update_scan_mode(struct iio_dev
> *indio_dev,
> const unsigned long *scan_mask)
> {
> struct adjd_s311_data *data = iio_priv(indio_dev);
> - data->buffer = krealloc(data->buffer, indio_dev->scan_bytes,
> - GFP_KERNEL);
> - if (!data->buffer)
> +
> + kfree(data->buffer);
> + data->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL);
> + if (data->buffer == NULL)
> return -ENOMEM;
>
> return 0;
>
--
Peter Meerwald
+43-664-2444418 (mobile)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
