On Aug 7, 2012, at 4:52 AM, Mark Brown wrote: > On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote: >> On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote: > >>> It's good practice to have an explict compatible string even if the >>> default happens to work in order to avoid any name clashes. > >> of_i2c.c makes no use whatsoever of the compatible string. See that it >> will build an i2c_boardinfo and register a new device. That compatible > > If that's all that's done it seems like a bug frankly, certainly based > on previous discussions it ought to be. There are collisions out there, > they've just happened to not bite us yet
Also keep in mind that the device tree is supposed to be a description of the hardware, and different implementations of the device tree may use the compatible string. Warner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
