On 08/03/2012 08:00 PM, Eric Dumazet wrote: > On Fri, 2012-08-03 at 16:23 +0200, Sasha Levin wrote: >> /* initialize hash table */ >> - for (bucket = 0; bucket < ERRHASHSZ; bucket++) >> - INIT_HLIST_HEAD(&hash_errmap[bucket]); >> + hash_init(&hash_errmap, ERRHASHSZ); > > Why is hash_init() even needed ? > > If hash is "DEFINE_STATIC_HASHTABLE(...)", its already ready for use !
Indeed it is. I've removed it, and then decided to put it back since the definition of the hashtable isn't fully cooked yet, and I didn't want to miss this initialization point if it turn out we need to initialize that hashtable afterall. I will remove it once the hashtable definitions are clear. The rest of the review comments will be addressed. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
