On Fri, 2012-08-03 at 11:27 -0700, Josh Triplett wrote: > scripts/get_maintainer.pl defaults to showing --rolestats, which > provides annotations explaining why each person or list might want to > know about a patch. This works well for interactive use, but breaks > when used with git send-email's --to-cmd or --cc-cmd, resulting in > malformed email headers and mails sent to some but not all recipients. > > To avoid the need to explicitly pass --no-rolestats for batch use, > enable --rolestats by default only when outputting to a terminal.
Hi Josh. I think it's preferable to add --no-rolestats to the uses that need them. I have different scripts that I use for git send-email options --to-cmd and --cc-cmd $ cat ~/bin/to.sh #!/bin/bash opts="--nogit --nogit-fallback --norolestats --pattern-depth=1" if [[ $(basename $1) =~ ^0000- ]] ; then ./scripts/get_maintainer.pl --nom $opts $(dirname $1)/* else maint=$(./scripts/get_maintainer.pl --nol $opts $1) if [ "$maint" == "" ] ; then echo "linux-kernel@vger.kernel.org" else echo "$maint" fi fi $ cat ~/bin/cc.sh #!/bin/bash opts="--nogit --nogit-fallback --norolestats" if [[ $(basename $1) =~ ^0000- ]] ; then ./scripts/get_maintainer.pl --nom $opts $(dirname $1)/* else ./scripts/get_maintainer.pl $opts $1 fi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/