On Tue, Jul 31, 2012 at 09:10:00AM +0200, Marc Kleine-Budde wrote:
> >>> +/*
> >>> + * Register CAN LED triggers for a CAN device
> >>> + *
> >>> + * This is normally called from a driver's probe function
> >>> + */
> >>> +void can_led_init(struct net_device *netdev)
> >>> +{
> >>> + struct can_priv *priv = netdev_priv(netdev);
> >>> +
> >>> + priv->tx_led_trig_name = kasprintf(GFP_KERNEL, "%s-tx", netdev->name);
> >>> + if (!priv->tx_led_trig_name)
> >>> + goto tx_led_failed;
> >>> +
> >>> + priv->rx_led_trig_name = kasprintf(GFP_KERNEL, "%s-rx", netdev->name);
> >>> + if (!priv->rx_led_trig_name)
> >>> + goto rx_led_failed;
> >>> +
> >>> + led_trigger_register_simple(priv->tx_led_trig_name,
> >>> + &priv->tx_led_trig);
> >>> + led_trigger_register_simple(priv->rx_led_trig_name,
> >>> + &priv->rx_led_trig);
> >>> +
> >>> + return;
> >>> +
> >>> +rx_led_failed:
> >>> + kfree(priv->tx_led_trig_name);
> >>> + priv->tx_led_trig_name = NULL;
> >>> +tx_led_failed:
> >>> + return;
> >>> +}
> >>> +EXPORT_SYMBOL_GPL(can_led_init);
> >>
> >> Can you provide a devm implementation for can_led?
> >
> > Sounds reasonable, you mean like a devm_kasprintf implementation to
> > remove kfree and unwinding code?
>
> IMHO it would be sufficient if you implement the devm cleanup functions
> here.
Uh - can you be more specific? I mean, are you suggesting to just
convert the code to something like:
unsigned int len;
char *p;
len = snprintf(NULL, 0, "%s-tx", netdev->name);
p = devm_kzalloc(&netdev->dev, len + 1, GFP_KERNEL);
if (!p)
return -ENOMEM;
sprintf(p, len + 1, "%s-tx", netdev->name);
or to implement something with devres_alloc() and a specific
release function?
Fabio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
