On Fri, 27 Jul 2012, Jan Beulich wrote: > >>> On 26.07.12 at 17:33, Stefano Stabellini > >>> <stefano.stabell...@eu.citrix.com> wrote: > > --- a/include/xen/interface/xen.h > > +++ b/include/xen/interface/xen.h > > @@ -10,7 +10,10 @@ > > #define __XEN_PUBLIC_XEN_H__ > > > > #include <asm/xen/interface.h> > > +#include <linux/types.h> > > +#ifdef CONFIG_X86 > > #include <asm/pvclock-abi.h> > > +#endif > > Rather than hacking around this, why not clean it up: > asm/pvclock-abi.h clearly isn't intended to be included here > (from the perspective of the origin of xen/interface/xen.h, at > least), nor is linux/types.h. > > Or if it is really needed to deviate from the original header in > this respect, then clearly the inclusion ought to not be arch > specific or be moved to an arch specific header.
I think you are right: linux/types.h is not actually needed and pvclock-abi.h should probably be included by asm/xen/interface.h. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
