On Tue, Jul 24, 2012 at 12:15 PM, Jeff Law <[email protected]> wrote:
>
> Please refer to the original discussion where they did evaluate the cost of
> this change and tested that the final change made no difference to the
> generated code.
Umm. That bugzilla entry seems to be talking about a *sane* change, namely
- ({ unsigned long int __d = (d); \
+ ({ unsigned long int __d = (unsigned long int) (d); \
in __FD_ELT(), which is totally different from the one Josh talks about.
In fact, that glibc change looks fine. The patch Josh has been pushing
has changed __NFDBITS to signed, and generates bad code. But
apparently that patch then didn't come from glibc at all?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
