Hi, On Tue, Jul 24, 2012 at 8:29 AM, Djalal Harouni <tix...@opendz.org> wrote: > This is the V2 to correctly check offsets on /proc/<pid>/environ before > reading. This was previously discussed here: > http://lkml.org/lkml/2012/7/22/79 > > Due to incorrect offset checks, currently one can read from aribtrary > addresses on /proc/<pid>/environ, not only the environment address range > as shown here (the same thread): > http://lkml.org/lkml/2012/7/22/163 > > The bug is in environ_read(). > [...] > Djalal Harouni (2): > proc: environ_read() make sure offset points to environment address range > proc: do not allow negative offsets on /proc/<pid>/environ > > fs/proc/base.c | 22 +++++++++++++--------- > 1 files changed, 13 insertions(+), 9 deletions(-)
This looks good, thanks! Acked-by: Kees Cook <keesc...@chromium.org> -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
