Em Fri, Jul 20, 2012 at 05:25:56PM -0600, David Ahern escreveu:
> 'perf kvm top' shows a continual flurry of:
> Can't find guest [5201]'s kernel information
>
> if it can't find the guest info and with a lot of VMs running a user
> has no chance of reading them all. Limit message to once per guest.
>
> Signed-off-by: David Ahern <dsah...@gmail.com>
> Cc: Arnaldo Carvalho de Melo <a...@ghostprotocols.net>
> Cc: Ingo Molnar <mi...@kernel.org>
> Cc: Jiri Olsa <jo...@redhat.com>
> Cc: Namhyung Kim <namhy...@kernel.org>
> Cc: Frederic Weisbecker <fweis...@gmail.com>
> Cc: Peter Zijlstra <pet...@infradead.org>
> ---
> tools/perf/builtin-top.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 1706dc9..6285374 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -706,8 +706,18 @@ static void perf_event__process_sample(struct perf_tool
> *tool,
> int err;
>
> if (!machine && perf_guest) {
> - pr_err("Can't find guest [%d]'s kernel information\n",
> - event->ip.pid);
> + static struct strlist *seen;
> + char pidstr[8];
> +
> + if (!seen)
> + seen = strlist__new(true, NULL);
> +
> + scnprintf(pidstr, sizeof(pidstr), "%d", event->ip.pid);
> + if (!strlist__has_entry(seen, pidstr)) {
> + pr_err("Can't find guest [%d]'s kernel information\n",
> + event->ip.pid);
> + strlist__add(seen, pidstr);
> + }
Abuse of strlist? Can't we have an intlist?
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
