On Mon, 16 Jul 2012 20:40:56 +0200, JoonSoo Kim <js1...@gmail.com> wrote:
2012/7/17 Michal Nazarewicz <min...@mina86.com>:
Joonsoo Kim <js1...@gmail.com> writes:
migrate_pages() would return positive value in some failure case,
so 'ret > 0 ? 0 : ret' may be wrong.
This fix it and remove one dead statement.
Signed-off-by: Joonsoo Kim <js1...@gmail.com>
Cc: Michal Nazarewicz <min...@mina86.com>
Cc: Marek Szyprowski <m.szyprow...@samsung.com>
Cc: Minchan Kim <minc...@kernel.org>
Cc: Christoph Lameter <c...@linux.com>
Have you actually encountered this problem? If migrate_pages() fails
with a positive value, the code that you are removing kicks in and
-EBUSY is assigned to ret (now that I look at it, I think that in the
current code the "return ret > 0 ? 0 : ret;" statement could be reduced
to "return ret;"). Your code seems to be cleaner, but the commit
message does not look accurate to me.
I don't encounter this problem yet.
If migrate_pages() with offlining false meets KSM page, then migration failed.
In this case, failed page is removed from cc.migratepage list and
return failed count.
Good point.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: m...@google.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
