> This makes mi->restartable unused?

It does ... but it's not what I meant ... somehow I lost the code that set 
MF_MUST_KILL
based on mi->restartable. Doh!

>> +    doit = !!PageDirty(ppage) || (flags & MF_MUST_KILL) != 0;
>
> Maybe
>
>                                    !!(flags & MF_MUST_KILL)

That fits stylistically with the other half of the "||" expression.

Thanks for the review. I'll update and resend.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to